add pregain + move postgain after sends #904
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if it would be possible to evaluate the fx and chain them in the order they are written also, then you might not even need all three gain types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
postgaincontrol was a bit misleading, as it was still applied before the effect sends. this PR adds another gain stage calledpregainbe the gain stage before the effect sends (but after local effects). Additionally, if a value is set topostgain, another gain stage will be added at the very end. this should allow full wet effects in the future. The signal path is now:source -> gain -> local fx -> pregain -> sends -> postgain